feat(link): add URL reachability checking#104
Merged
corylanou merged 4 commits intoMar 16, 2026
Merged
Conversation
Add opt-in link validation that checks whether URLs in documents are reachable via HTTP. Implements HEAD-first-then-GET checking with per-host rate limiting, URL caching, configurable timeouts, exclude patterns, redirect following, and 429 retry-after support. Closes #101
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16a6a925cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Fix exclude patterns to match nested URL paths using prefix matching - Deduplicate concurrent checks for the same URL via inflight map - Reject non-positive link-rate values with safe defaults
- Fall back to GET when HEAD returns non-accepted status (not just 405) - Normalize protocol-relative URLs (//example.com) to https - Fix off-by-one in redirect limit (allow exactly MaxRedirects hops)
- Merge partial configs with defaults in NewLinkValidator - Apply link timeout to rate-limit waits and retry-after sleeps - Clear parser link-check state when flag is off
corylanou
deleted the
issue-101-feat-add-link-validation-url-reachability-checking
branch
March 16, 2026 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in link validation that checks whether
<a href>URLs in hype documents are reachable, complementing existing local asset validation (images, source files).Related Issue
Closes #101
Changes
LinkCheckConfigstruct with configurable timeout, accepted status codes, exclude patterns, rate limiting, and max redirectsLinkValidatorwith HEAD-first/GET-fallback HTTP checking, per-URL caching, per-host rate limiting viax/time/rate, and 429 Retry-After supportLinkCheckErrortype for structured error reportingExecute()method toLinktype, making it implementExecutableNode— only active when link checking is enabledLinkCheckandLinkValidatorfields toParser, propagated throughSub()for sub-directory parsinghype export:--check-links,--link-timeout,--link-exclude,--link-rateTest Plan
go test ./...— pre-existing snapshot test failure unrelated to this PR)Breaking Changes
None — link checking is opt-in (off by default). No existing behavior changes.